static_url is a greedy regex
Reported by nciagra | July 22nd, 2008 @ 01:10 PM | in REL 0.9.15
The source for build tools' static_url currently uses a greedy regular expression, resulting in any calls to static_url that have a string after resulting in a Merb error. To fix this error, replace the regular expression (for me, line 62) in the resource_builder.rb file with the following:
line.gsub(/static_url\([\'\"](.+?)[\'\"]\)/) do | rsrc |
This makes the regex non-greedy and fixes the bug.
Comments and changes to this ticket
-
Charles Jolley August 9th, 2008 @ 07:38 PM
- → Milestone changed from “” to “REL 0.9.15”
- → State changed from “new” to “resolved”
Good catch. Applied and pushed. Thanks.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
SproutCore: JavaScript Application Framework
Source available from github
The Git repository resides at http://github.com/sproutit
Check out the current development trunk with:
git clone git://github.com/sproutit/sproutcore.git
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Submitting Patches
Resist adding new tags, use the ones in the tag cloud already. If you are submitting a patch or a pull request from a fork, tag the ticket as a "patch". If you are submitting a new feature enhancement, tag it as "enhancement". If you are submitting a fix for a bug, tag it as "fix".
Thanks!
We're glad you're contributing. Feel free to drop by the Google Group as well to let us know you are involved.
