Inline detect-browser
Reported by August Joki | July 22nd, 2008 @ 07:24 PM | in REL 0.9.21
Would be nice if detect-browser was inlined as it's tiny and it would save network roundtrip and whatnot.
Comments and changes to this ticket
-
Charles Jolley August 9th, 2008 @ 07:34 PM
- → Milestone changed from “” to “Unscheduled”
- → State changed from “new” to “open”
-
Lawrence Pit August 13th, 2008 @ 11:44 PM
I'm not in favor of this. Please keep the index file as small and simple as possible.
Couldn't detect-browser be yielded as the first resource? Then when you do c[:combine_javascript] it should be included in the big one..
-
Erich Ocean (onitunes) September 30th, 2008 @ 04:17 AM
- → Milestone changed from “Unscheduled” to “REL 0.9.21”
- → State changed from “open” to “hold”
- → Assigned user changed from “” to “Erich Ocean (onitunes)”
detect-browser is included in <head> because it is required by already inlined at the top of <body>. I think we should inline it in <head> for three reasons:
- it saves a round-trip to the server
- detect-browser contains no ".js" extension and fails to load properly at times on Windows/IE.
- it's tiny and will not appreciably impact the size of index.html
In all likelihood, the gzipped size of index.html will be less than 4Kb in all cases, so the impact on serving it will be small whereas latency will be improved, and thus load times.
-
Erich Ocean (onitunes) November 8th, 2008 @ 09:28 AM
- → Assigned user cleared.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
SproutCore: JavaScript Application Framework
Source available from github
The Git repository resides at http://github.com/sproutit
Check out the current development trunk with:
git clone git://github.com/sproutit/sproutcore.git
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Submitting Patches
Resist adding new tags, use the ones in the tag cloud already. If you are submitting a patch or a pull request from a fork, tag the ticket as a "patch". If you are submitting a new feature enhancement, tag it as "enhancement". If you are submitting a fix for a bug, tag it as "fix".
Thanks!
We're glad you're contributing. Feel free to drop by the Google Group as well to let us know you are involved.
